exporters/glance: bugfix image_bytes when slow metrics are disabled #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddbc6e0
to
65f9f68
Compare
when set option `disabled slow metric` disabled exporter try to create some metric for prometheus in exporter.Metrics["images_bytes"] which is not exist if slow metrics are disabled in version 1.6.0 this problem cause panic if slow metrics is set to disabled Signed-off-by: Parsa <[email protected]>
65f9f68
to
d23917e
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when set option
disabled slow metricdisabled exporter try to create some metric for prometheus inexporter.Metrics["images_bytes"] which is not exist if slow metrics are disabled
in version 1.6.0 this problem cause panic if slow metrics is set to disabled
Signed-off-by: Parsa [email protected]