Add limits values for instances #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@niedbalski I was scrolling through issues and noticed this one: #83 The user did not describe exactly which quota they would need, but I could open a new PR or extend this one if you want to add the other quota metrics as well. |
Hello @jocelynthode Please go ahead and I'll review. |
mzijdemans
pushed a commit
to mzijdemans/openstack-exporter
that referenced
this pull request
Dec 27, 2022
Co-authored-by: Jorge Niedbalski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @niedbalski ,
I'm back with another PR to add more metrics about the limits set. The exporter already had them for vcpus and memory but I did not find them for instances.
I could also add other metrics in this PR if you'd like. (e.g.: Floating ip used).
This would be a nice addition for me as we could then monitor when a tenant gets close to its max capacity :)
Let me know if this works for you or if you'd like me to add/modify this PR.