Add support for proxy #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rustyclock <[email protected]>
niedbalski
reviewed
Nov 12, 2020
|
LGTM, quick observation. Also, if you could update the README.md explaining that proxy will be configured from the environment. |
|
@rustycl0ck any feedback on this? |
|
@niedbalski sorry for the late response. I don't think I'll be able to spend time on testing/modifying this in the immediate future. I see that @ichtar has been trying it out. So I'll hand it over to them for now until I can spend time on this again. |
|
LGTM |
mzijdemans
pushed a commit
to mzijdemans/openstack-exporter
that referenced
this pull request
Dec 27, 2022
* Add support for proxy Signed-off-by: rustyclock <[email protected]> * move proxy to utils Co-authored-by: JeaNoel Vouilloz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #117