Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Add IP Address Label To Neutron Port #289

Closed
alirezarm78 opened this issue Jul 17, 2023 · 6 comments · Fixed by #323
Closed

[Feature Request] Add IP Address Label To Neutron Port #289

alirezarm78 opened this issue Jul 17, 2023 · 6 comments · Fixed by #323

Comments

@alirezarm78
Copy link

Hello.
I hope that we have fixed_ip_address label for neutron port metric, we really need it.
Thank you.
@odnobit
Copy link
Contributor

odnobit commented Sep 5, 2023

@niedbalski I can take this task.

@odnobit
Copy link
Contributor

odnobit commented Sep 12, 2023

Hello @alirezarm78!
I'm waiting for my neutron PR review and merge to avoid conflicts.

@alirezarm78
Copy link
Author

Hello dear @odnobit
In your PR i can't see anything about this feature request
Can you explain it?

@odnobit
Copy link
Contributor

odnobit commented Sep 12, 2023

Hello dear @odnobit In your PR i can't see anything about this feature request Can you explain it?

Sure. I'm waiting when my current PR will be merged because conflicts are possible. And then I will start working for your requested feature.

@alirezarm78
Copy link
Author

Dear @odnobit after your PR merged, can you start final commits for this feature request?

@odnobit
Copy link
Contributor

odnobit commented Feb 8, 2024

yea, sure

odnobit added a commit to odnobit/openstack-exporter that referenced this issue Feb 8, 2024
@odnobit
Resolve openstack-exporter#289 | Add floating_ips label to port
5f36823 
* Added the 'floating_ips' label to the neutron-port metric
* If a port has more than one fixed_ip,
  they are now joined into a comma-separated string
@odnobit odnobit mentioned this issue Feb 8, 2024
Merged
niedbalski pushed a commit that referenced this issue Feb 20, 2024
@odnobit @niedbalski
Resolve #289 | Add floating_ips label to port
1a2e113 
* Added the 'floating_ips' label to the neutron-port metric
* If a port has more than one fixed_ip,
  they are now joined into a comma-separated string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve #289 | Add floating_ips label to port odnobit/openstack-exporter
2 participants
@alirezarm78 @odnobit