-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In OpenSSL 3, ASN1_item_verify*() can return 2 on error. #24575
Labels
branch: 3.0
Merge to openssl-3.0 branch
branch: 3.1
Merge to openssl-3.1
branch: 3.2
Merge to openssl-3.2
branch: 3.3
Merge to openssl-3.3
severity: important
Important bugs affecting a released version
triaged: bug
The issue/pr is/fixes a bug
Comments
t8m
added a commit
to t8m/openssl
that referenced
this issue
Jun 6, 2024
Fix in #24576 |
t8m
added a commit
to t8m/openssl
that referenced
this issue
Jun 17, 2024
This is a test for openssl#24575 Original idea by Theo Buehler.
t8m
added a commit
to t8m/openssl
that referenced
this issue
Jun 17, 2024
This is a test for openssl#24575 Original idea by Theo Buehler.
openssl-machine
pushed a commit
that referenced
this issue
Jun 21, 2024
This is a test for #24575 Original idea by Theo Buehler. Reviewed-by: Tom Cosgrove <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from #24576)
openssl-machine
pushed a commit
that referenced
this issue
Jun 21, 2024
Fixes #24575 Reviewed-by: Tom Cosgrove <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from #24576) (cherry picked from commit 8d380f8)
openssl-machine
pushed a commit
that referenced
this issue
Jun 21, 2024
This is a test for #24575 Original idea by Theo Buehler. Reviewed-by: Tom Cosgrove <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from #24576) (cherry picked from commit 2f0b497)
openssl-machine
pushed a commit
that referenced
this issue
Jun 21, 2024
Fixes #24575 Reviewed-by: Tom Cosgrove <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from #24576) (cherry picked from commit 8d380f8)
openssl-machine
pushed a commit
that referenced
this issue
Jun 21, 2024
This is a test for #24575 Original idea by Theo Buehler. Reviewed-by: Tom Cosgrove <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from #24576) (cherry picked from commit 2f0b497)
openssl-machine
pushed a commit
that referenced
this issue
Jun 21, 2024
Fixes #24575 Reviewed-by: Tom Cosgrove <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from #24576) (cherry picked from commit 8d380f8)
openssl-machine
pushed a commit
that referenced
this issue
Jun 21, 2024
Fixes #24575 Reviewed-by: Tom Cosgrove <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from #24576) (cherry picked from commit 8d380f8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
branch: 3.0
Merge to openssl-3.0 branch
branch: 3.1
Merge to openssl-3.1
branch: 3.2
Merge to openssl-3.2
branch: 3.3
Merge to openssl-3.3
severity: important
Important bugs affecting a released version
triaged: bug
The issue/pr is/fixes a bug
Introduced in #10942 as part of extracting
ASN1_item_verify_ctx()
fromASN1_item_verify()
when aret = -1;
was deleted after thegoto err
here:openssl/crypto/asn1/a_verify.c
Lines 143 to 154 in 5bbdbce
If
item_verify()
returns2
(which it usually will for RSA-PSS for example) the control flow would skip here and return 2 ifASN1_item_i2d()
errors:openssl/crypto/asn1/a_verify.c
Lines 202 to 210 in 5bbdbce
The text was updated successfully, but these errors were encountered: