Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search functionality for map fragment #3313

Closed
wants to merge 25 commits into from

Conversation

aurangzaibumer
Copy link
Contributor

@aurangzaibumer aurangzaibumer commented Jun 4, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes https://github.com/onaio/fhir-resources/issues/3255

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@aurangzaibumer aurangzaibumer self-assigned this Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 13.63636% with 57 lines in your changes missing coverage. Please review.

Project coverage is 28.2%. Comparing base (1a3dbd4) to head (d7b1a2a).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3313     +/-   ##
=========================================
- Coverage     28.2%   28.2%   -0.1%     
- Complexity     720     727      +7     
=========================================
  Files          265     265             
  Lines        12711   12754     +43     
  Branches      2261    2266      +5     
=========================================
+ Hits          3596    3605      +9     
- Misses        8646    8679     +33     
- Partials       469     470      +1     
Flag Coverage Δ
engine 65.0% <0.0%> (-0.1%) ⬇️
geowidget 20.5% <52.9%> (+2.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...core/engine/domain/model/TopScreenSectionConfig.kt 14.2% <0.0%> (-2.4%) ⬇️
...r/fhircore/geowidget/screens/GeoWidgetViewModel.kt 94.4% <90.0%> (-1.1%) ⬇️
...ister/fhircore/quest/ui/register/RegisterScreen.kt 0.0% <0.0%> (ø)
...re/quest/ui/launcher/GeoWidgetLauncherViewModel.kt 0.0% <0.0%> (ø)
...rcore/quest/ui/launcher/GeoWidgetLauncherScreen.kt 0.0% <0.0%> (ø)
...ore/quest/ui/launcher/GeoWidgetLauncherFragment.kt 0.0% <0.0%> (ø)
...er/fhircore/geowidget/screens/GeoWidgetFragment.kt 0.5% <0.0%> (+<0.1%) ⬆️
...rcore/quest/ui/main/components/TopScreenSection.kt 0.0% <0.0%> (ø)

@aurangzaibumer
Copy link
Contributor Author

@ellykits this is currently in WIP state/Not finalized.

@aurangzaibumer
Copy link
Contributor Author

Updating few things before marking ready for review.

@aurangzaibumer aurangzaibumer marked this pull request as ready for review June 7, 2024 07:27
@aurangzaibumer aurangzaibumer changed the title WIP working on search functionality for map fragment search functionality for map fragment Jun 7, 2024
@aurangzaibumer
Copy link
Contributor Author

@ellykits I have separated the shared search functionality part from this PR, this PR only contains search functionality done on the map fragment.

@ellykits
Copy link
Collaborator

Can you reference the issue on this PR @aurangzaibumer?

@aurangzaibumer
Copy link
Contributor Author

Can you reference the issue on this PR @aurangzaibumer?

done, sir.

@aurangzaibumer
Copy link
Contributor Author

Updating tests...

@aurangzaibumer
Copy link
Contributor Author

Closing this PR as @ellykits worked on a new implementation which will be replaced by this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants