Fixed get_definition_by_name()

[SpookedByRoaches]

Fixed get_definition_by_name() so that it does not get deleted definitions.

[jekkos]

What behavior does it fix exactly? Do selected attributes still show in case you delete a definition?

[SpookedByRoaches]

What behavior does it fix exactly? Do selected attributes still show in case you delete a definition?

When adding an item by importing a CSV, it adds an attribute link for the first attribute that comes out of the query. So if you have an attribute that you deleted and added again, it would add an attribute link with the ID of the deleted attribute when importing.

Let's say you have color attribute and you added it as string type at first, then deleted it and added another attribute with the same name but with dropdown instead. Now the attribute with the string type is still there in the attribute_definitions but the deleted column is 1. If you import through the CSV, it would pick likely pick the deleted one since it doesn't have a condition that the definition is not deleted.