-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: riskanalysis: improve request retries #28961
NO-JIRA: riskanalysis: improve request retries #28961
Conversation
I observed that when a RA http request fails for any reason, retries also fail immediately. Stephen speculated that reusing the request object might be a problem. What I could find indicated that would only be a problem in specialized circumstances but it seemed worth trying.
a57c041
to
5bb32d2
Compare
Job Failure Risk Analysis for sha: 5bb32d2
|
Latest change seems to have fixed it. I get the feeling sharing the context was the problem. Results that show retries working as they should: |
/retest-required |
@sosiouxme: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest-required |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neisw, sosiouxme The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sosiouxme: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
04973c8
into
openshift:master
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
I observed that when a RA http request fails for any reason, retries also fail immediately. Stephen speculated that reusing the request object might be a problem. What I could find indicated that would only be a problem in specialized circumstances but it seemed worth trying.