NO-JIRA: riskanalysis: improve request retries

[sosiouxme]

I observed that when a RA http request fails for any reason, retries also fail immediately. Stephen speculated that reusing the request object might be a problem. What I could find indicated that would only be a problem in specialized circumstances but it seemed worth trying.

[sosiouxme]

did not solve the problem :(

[openshift-trt-bot]

Job Failure Risk Analysis for sha: 5bb32d2

Job Name

Failure Risk

pull-ci-openshift-origin-master-e2e-aws-ovn-ipsec-serial

High [sig-cluster-lifecycle] pathological event should not see excessive Back-off restarting failed containers for ns/openshift-multus This test has passed 100.00% of 55 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-serial'] in the last 14 days. --- [sig-arch] events should not repeat pathologically for ns/openshift-ovn-kubernetes This test has passed 100.00% of 55 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-serial'] in the last 14 days.

[sosiouxme]

Latest change seems to have fixed it. I get the feeling sharing the context was the problem. Results that show retries working as they should:

1. timed out, 2nd try succeeded
2. timed out, 2nd try succeeded
3. timed out all 3 tries

[sosiouxme]

/retest-required

[openshift-ci-robot]

@sosiouxme: This pull request explicitly references no jira issue.

In response to this:

I observed that when a RA http request fails for any reason, retries also fail immediately. Stephen speculated that reusing the request object might be a problem. What I could find indicated that would only be a problem in specialized circumstances but it seemed worth trying.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sosiouxme]

/retest-required

[neisw]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neisw, sosiouxme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [neisw,sosiouxme]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@sosiouxme: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-ipsec-serial	5bb32d2	link	false	/test e2e-aws-ovn-ipsec-serial
ci/prow/e2e-aws-ovn-single-node	5bb32d2	link	false	/test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.18.0-202408010449.p0.g04973c8.assembly.stream.el9.
All builds following this will include this PR.