WRKLDS-1431: e2e: migrate DCs to Deployments #28957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d1ca886
to
e5d212a
Compare
|
Job Failure Risk Analysis for sha: e5d212a
|
|
@ingvagabund: This pull request references WRKLDS-1431 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Job Failure Risk Analysis for sha: a478e09
|
a478e09
to
6c08ffa
Compare
|
Job Failure Risk Analysis for sha: 6c08ffa
|
|
@ingvagabund: This pull request references WRKLDS-1431 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
6c08ffa
to
27cb911
Compare
|
@ingvagabund: This pull request references WRKLDS-1431 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ingvagabund: This pull request references WRKLDS-1431 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ingvagabund: This pull request references WRKLDS-1431 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
f280933
to
481a9d3
Compare
|
@ingvagabund: This pull request references WRKLDS-1431 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ingvagabund: This pull request references WRKLDS-1431 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Job Failure Risk Analysis for sha: 481a9d3
|
|
Job Failure Risk Analysis for sha: 59ecd44
|
|
/retest-required |
592fd1a
to
409d1d8
Compare
Based on https://prow.ci.openshift.org/job-history/gs/test-platform-results/pr-logs/directory/pull-ci-openshift-origin-master-e2e-gcp-ovn-builds the job has been failing for other PRs as well.
Often failing with failed installation |
|
/retest-required |
|
Job Failure Risk Analysis for sha: 7dc2074
|
…emove [apigroup:apps.openshift.io] API dependency
… [apigroup:apps.openshift.io] API dependency
…oup:apps.openshift.io] API dependency
…enshift.io] API dependency
…enshift.io] API dependency
…shift.io] API dependency
7dc2074
to
c7d34f8
Compare
dgoodwin
reviewed
Oct 8, 2024
| @@ -51,7 +49,7 @@ var _ = g.Describe("[sig-builds][Feature:Builds][volumes] build volumes", func() | |||
| } | |||
| }) | |||
|
|
|||
| g.It("should mount given secrets and configmaps into the build pod for source strategy builds [apigroup:image.openshift.io][apigroup:build.openshift.io][apigroup:apps.openshift.io]", func() { | |||
| g.It("should mount given secrets and configmaps into the build pod for source strategy builds [apigroup:image.openshift.io][apigroup:build.openshift.io]", func() { | |||
There was a problem hiding this comment.
Can't remember if we discussed this before but you may want to rename these tests in the test mapping repo so history carries over and component readiness can compare to past releases. Unless, you feel this is now a new test that should not be compared anymore?
"New" tests may soon be required to have a very high pass rate 99% by component readiness.
There was a problem hiding this comment.
We did :) I have a PR ready for the mapping: openshift-eng/ci-test-mapping#148. Once this merges I will update the mapping accordingly.
|
/payload 4.18-nightly-blocking |
|
/payload 4.18 nightly blocking |
|
@dgoodwin: trigger 11 job(s) of type blocking for the nightly release of OCP 4.18
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6a604170-856c-11ef-96e9-71f623562d4d-0 |
ardaguclu
reviewed
Oct 8, 2024
| out, err := oc.Run("status").Args("-h").Output() | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
| o.Expect(out).To(o.ContainSubstring("oc describe buildconfig")) | ||
|
|
||
| out, err = oc.Run("status").Output() | ||
| out, err = oc.Run("status").Args("--suggest").Output() |
There was a problem hiding this comment.
What is the reason of this change?
There was a problem hiding this comment.
oc status prints a different output that does not contain "oc new-app" text when DC API is disabled. --suggest puts the text back.
| @@ -81,7 +81,7 @@ os::cmd::expect_success 'oc delete all --all' | |||
| sleep 1 | |||
| os::cmd::expect_success 'oc delete all --all' | |||
|
|
|||
| os::cmd::expect_success 'oc process -f ${TEST_DATA}/application-template-dockerbuild.json -l app=dockerbuild | oc create -f -' | |||
| os::cmd::expect_success 'oc process -f ${TEST_DATA}/application-template-dockerbuild-dc.json -l app=dockerbuild | oc create -f -' | |||
There was a problem hiding this comment.
Is this test the only existence reason of application-template-dockerbuild-dc.json?. If yes, why don't we remove this test as well as this json file?
There was a problem hiding this comment.
As far as I understand, this is the only piece in origin referencing deploymentconfig and it is better to remove it.
There was a problem hiding this comment.
deployment.sh is still testing some of the DC functionality. I'd prefer to keep it and remove it once deployment.sh gets migrated to a go based test.
|
ipsec-serial is already broken and |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, dgoodwin, ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
/retest-required |
1 similar comment
|
/retest-required |
|
@ingvagabund: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5693bd4
into
openshift:master
28 of 30 checks passed
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated:
[Serial] [sig-auth][Feature:OAuthServer] [RequestHeaders] [IdP] test RequestHeaders IdP [apigroup:config.openshift.io][apigroup:user.openshift.io]: works without DC API enabled[sig-builds][Feature:Builds][volumes] ...: migrating with triggers[sig-cli] oc --request-timeout works as expected: creating a deployment instead of a DC[sig-cli] oc adm build-chain [apigroup:build.openshift.io][apigroup:image.openshift.io][apigroup:project.openshift.io]: migrating with triggers[sig-cli] oc builds ...: migrating with triggers[sig-cli] oc debug ensure debug does not depend on a container actually existing for the selected resource: duplicating for deployments[sig-cli] oc env can set environment variables: migrating with triggers[sig-cli] oc idle [apigroup:apps.openshift.io][apigroup:route.openshift.io][apigroup:project.openshift.io][apigroup:image.openshift.io] by ...: duplicated and changed for deployments[sig-cli] oc run can use --image flag correctly: creating a deployment instead of a DC[sig-cli] oc set image can set images for pods and deployments: migrating with triggers[sig-cli] oc status returns expected help messages: works without DC as long as --suggest arg is provided[sig-cli] templates process: migrating with triggers[sig-devex][Feature:Templates] templateinstance readiness test: migrating with triggers[sig-devex][Feature:ImageEcosystem][perl][Slow] hot deploy for openshift perl image hot deploy test should work [apigroup:image.openshift.io][apigroup:operator.openshift.io][apigroup:config.openshift.io][apigroup:build.openshift.io][apigroup:apps.openshift.io]: migrating with triggers + replacing all the waiting code and Deployment -> RS -> pod retrival code.[sig-imageregistry][Feature:ImageLookup] Image policy should update OpenShift object image fields when local names are on:[sig-network-edge][Feature:Idling] Unidling ...: simple DC replacement (no triggers)[sig-scheduling][Early] The openshift-apiserver pods [apigroup:apps.openshift.io][apigroup:authorization.openshift.io][apigroup:build.openshift.io][apigroup:image.openshift.io][apigroup:project.openshift.io][apigroup:quota.openshift.io][apigroup:route.openshift.io][apigroup:security.openshift.io][apigroup:template.openshift.io] should be scheduled on different nodes: already without DC dependency, just removing the apigroup.Ignoring:
[sig-imageregistry][Feature:ImageLookup] Image policy should update OpenShift object image fields when local names are on [apigroup:image.openshift.io][apigroup:apps.openshift.io]: testing DCs[sig-imageregistry][Feature:ImagePrune][Serial][Suite:openshift/registry/serial][Local] Image hard prune [apigroup:apps.openshift.io][apigroup:user.openshift.io] should delete orphaned blobs [apigroup:image.openshift.io]: not running at all, fails on missing dc/docker-registry.[sig-imageregistry][Feature:ImagePrune][Serial][Suite:openshift/registry/serial][Local] Image hard prune [apigroup:apps.openshift.io][apigroup:user.openshift.io] should show orphaned blob deletions in dry-run mode [apigroup:image.openshift.io]: not running at all, fails on missing dc/docker-registry.[sig-devex][Feature:ImageEcosystem][mariadb][Slow] openshift mariadb image Creating from a template should instantiate the template [apigroup:image.openshift.io][apigroup:operator.openshift.io][apigroup:config.openshift.io][apigroup:apps.openshift.io]: broken[sig-devex][Feature:ImageEcosystem][mysql][Slow] openshift mysql image Creating from a template should instantiate the template [apigroup:apps.openshift.io]: broken[sig-cli] oc probe can ensure the probe command is functioning as expected on deploymentconfigs [apigroup:apps.openshift.io]: testing DCsoc explain should contain spec+status for apps.openshift.io [apigroup:apps.openshift.io]: testing DCsoc explain should contain proper fields description for apps.openshift.io [apigroup:apps.openshift.io]: testing DCs[sig-cli] oc basics can create deploymentconfig and clusterquota [apigroup:apps.openshift.io]: testing DCs[sig-scalability][Feature:Performance] Load cluster should populate the cluster [Slow][Serial]: broken by Use UBI8 instead of SCL images #26072 as the e2e is expected to be run separately: The following error is produced:[sig-scalability]: can't find any run in https://search.dptools.openshift.org/?search=%5C%5Bsig-scalability%5C%5D&maxAge=48h&context=1&type=junit&name=&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job