-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start-build: remove false alarm warning for repo binary input #20100
start-build: remove false alarm warning for repo binary input #20100
Conversation
4b7cc00
to
def52d8
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, wozniakjan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest flake #20101 |
/retest
|
/hold cancel |
/refresh |
/retest Please review the full test history for this PR and help us cut down flakes. |
I was able to create a zip archive that was as little as 183 bytes with valid but very short Dockerfile as the only file, so the peek was too large even for an archive created differently than from git repo and should probably not warn a false alarm
ptal @openshift/sig-developer-experience
including the conversation for reference #20090
also, I think the magic number for .gz was not completely correct, it had an extra byte (which is used to signal "deflate" compression algorithm but the byte can have different values as well and still denote .gz archive)
RFC for reference: https://tools.ietf.org/html/rfc1952