Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Fix manage_hypervisor_config.sh script to finish cleanup procedure #3873

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Sep 6, 2024

Minor fix in the cleanup procedure to avoid errors like the following, which aborts the script in the middle:

$ bash -x ./test/bin/manage_hypervisor_config.sh cleanup
...
...
+ sudo virsh net-info isolated
+ sudo virsh net-info ipv6
++ sudo virsh net-dumpxml ipv6
++ yq -p xml .network.bridge.+@name
+ bridge_name=virbr3
+ sudo ip link del name virbr3p0
Cannot find device "virbr3p0"

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 6, 2024
@openshift-ci-robot
Copy link

@ggiguash: This pull request explicitly references no jira issue.

In response to this:

Minor fix in the cleanup procedure to avoid errors like there stopping the script in the middle:

$ bash -x ./test/bin/manage_hypervisor_config.sh cleanup
...
...
+ sudo virsh net-info isolated
+ sudo virsh net-info ipv6
++ sudo virsh net-dumpxml ipv6
++ yq -p xml .network.bridge.+@name
+ bridge_name=virbr3
+ sudo ip link del name virbr3p0
Cannot find device "virbr3p0"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from copejon and jogeo September 6, 2024 06:58
Copy link
Contributor

openshift-ci bot commented Sep 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2024
Copy link
Contributor

openshift-ci bot commented Sep 6, 2024

@ggiguash: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/microshift-metal-tests-arm afa4a8f link true /test microshift-metal-tests-arm
ci/prow/metal-periodic-test-arm afa4a8f link true /test metal-periodic-test-arm
ci/prow/metal-bootc-periodic-test-arm afa4a8f link true /test metal-bootc-periodic-test-arm
ci/prow/metal-periodic-test afa4a8f link true /test metal-periodic-test
ci/prow/metal-bootc-periodic-test afa4a8f link true /test metal-bootc-periodic-test
ci/prow/microshift-metal-tests afa4a8f link true /test microshift-metal-tests
ci/prow/metal-bootc-test-arm afa4a8f link true /test metal-bootc-test-arm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants