Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MicroShift Prometheus Exporter #3805

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

agullon
Copy link
Contributor

@agullon agullon commented Aug 22, 2024

Which issue(s) this PR addresses:

Closes #

@openshift-ci openshift-ci bot requested review from jerpeter1 and pmtk August 22, 2024 10:58
Copy link
Contributor

openshift-ci bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: agullon
Once this PR has been reviewed and has the lgtm label, please assign jogeo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agullon
Copy link
Contributor Author

agullon commented Aug 22, 2024

@ggiguash should I, do we need a ticket for this?

Copy link
Contributor

openshift-ci bot commented Sep 2, 2024

@agullon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

- MicroShift installed and running
- Go version >= 1.21.11

## Steps to run it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the numbering from the section?

Let's just explain each step in a separate paragraph and there won't be a need to use tabulation too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this file to images sub-dir?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this file to config sub-dir?

```

## Grafana dashboard
You can get a [Grafana dashboard example here](grafana_dashboard.json):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we explain a bit more about how to use this JSON file?
I mean, is there a way to use grafana container to easily bootstrap the UI? How?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants