USHIFT-3482: Add ipv6 advertiseAddress handling #3534
Conversation
|
@pacevedom: This pull request references USHIFT-3482 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
approved
|
/test microshift-metal-tests-arm |
1 similar comment
|
/test microshift-metal-tests-arm |
|
/lgtm |
|
/lgtm cancel |
| @@ -280,7 +280,11 @@ func (c *Config) updateComputedValues() error { | |||
| // host network pods trying to reach apiserver, as the VIP 10.43.0.1:443 is | |||
| // not translated to 10.43.0.1:6443. It remains unchanged and therefore | |||
| // connects to the ingress router instead, triggering all sorts of errors. | |||
| nextSubnet, exceed := cidr.NextSubnet(svcNet, 32) | |||
| prefix := 32 | |||
There was a problem hiding this comment.
I think we need to re-vendor microshift in etcd/
pacevedom
force-pushed
the
USHIFT-3482-advertise-address
branch
from
1cb7835
to
8464e30
Compare
|
/lgtm |
|
/test microshift-metal-tests-arm |
3 similar comments
|
/test microshift-metal-tests-arm |
|
/test microshift-metal-tests-arm |
|
/test microshift-metal-tests-arm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pacevedom, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test microshift-metal-tests-arm |
1 similar comment
|
/test microshift-metal-tests-arm |
|
@pacevedom: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Which issue(s) this PR addresses:
Closes #