Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-3482: IPv6 handling adjustments in configuration #3528

Merged
merged 8 commits into from
Jun 28, 2024
Merged

USHIFT-3482: IPv6 handling adjustments in configuration #3528

merged 8 commits into from
Jun 28, 2024

Conversation

pacevedom
Copy link
Contributor

Which issue(s) this PR addresses:

Closes #

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 21, 2024 •
edited by openshift-ci bot
Loading

@pacevedom: This pull request references USHIFT-3482 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 21, 2024
@openshift-ci openshift-ci bot requested review from copejon and jogeo June 21, 2024 10:41
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2024
@pacevedom
Copy link
Contributor Author

/test microshift-metal-tests-arm
/test microshift-metal-tests

@pacevedom
Copy link
Contributor Author

/test microshift-metal-tests
/test microshift-metal-tests-arm

@pacevedom pacevedom changed the title USHIFT-3482: IPv6 handling adjustents in configuration USHIFT-3482: IPv6 handling adjustments in configuration Jun 24, 2024
pmtk
pmtk reviewed Jun 26, 2024
View reviewed changes
pkg/util/net.go
@@ -117,15 +116,6 @@ func RetryTCPConnection(ctx context.Context, host string, port string) bool {
return status
}

func CreateLocalhostListenerOnPort(port int) (tcpnet.Listener, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think etcd needs to re-vendor microshift

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@pmtk
Copy link
Member

pmtk commented Jun 26, 2024

/lgtm

1 similar comment
@pmtk
Copy link
Member

pmtk commented Jun 27, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacevedom
Copy link
Contributor Author

/test microshift-metal-tests-arm

3 similar comments
@pacevedom
Copy link
Contributor Author

/test microshift-metal-tests-arm

@pacevedom
Copy link
Contributor Author

/test microshift-metal-tests-arm

@pacevedom
Copy link
Contributor Author

/test microshift-metal-tests-arm

@pacevedom
Copy link
Contributor Author

/test microshift-metal-tests

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a73844c and 2 for PR HEAD 6be85fb in total

@pacevedom
Copy link
Contributor Author

/test microshift-metal-tests-arm
/test microshift-metal-tests

@pacevedom
Copy link
Contributor Author

/test microshift-metal-tests
/test microshift-metal-tests-arm

@pacevedom
Copy link
Contributor Author

/test microshift-metal-tests-arm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 28, 2024

@pacevedom: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 7871deb into openshift:main Jun 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmtk pmtk pmtk left review comments

@copejon copejon Awaiting requested review from copejon

@jogeo jogeo Awaiting requested review from jogeo

Assignees

@pmtk pmtk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pacevedom @openshift-ci-robot @pmtk