Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Add runtime crun to crio for y-2 blueprint #3527

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented Jun 21, 2024

microshift 4.15 RPM still specifies crio >= 1.25 and doesn't ship its own crun runtime definition for crio. When it gets newest crio (>= 1.29), the test fails because crio exits shortly after startup.
This PR introduces a workaround: explicitly adds missing file to the blueprint.
When 4.15 RPM has its crio version fixed, we can remove the workaround.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 21, 2024
@openshift-ci-robot
Copy link

@pmtk: This pull request explicitly references no jira issue.

In response to this:

microshift 4.15 RPM still specifies crio >= 1.25 and doesn't ship its own crun runtime definition for crio. When it gets newest crio (>= 1.29), the test fails because crio exits shortly after startup.
This PR introduces a workaround: explicitly adds missing file to the blueprint.
When 4.15 RPM has its crio version fixed, we can remove the workaround.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jogeo and pliurh June 21, 2024 09:29
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2024
@pmtk
Copy link
Member Author

pmtk commented Jun 21, 2024

/override ci/prow/microshift-metal-tests ci/prow/microshift-metal-tests-arm

Because test we're trying to fix here is using images from cache, it's not taking into consideration change in this PR. We need to merge this, so next night it's rebuilt.

Copy link
Contributor

openshift-ci bot commented Jun 21, 2024

@pmtk: Overrode contexts on behalf of pmtk: ci/prow/microshift-metal-tests, ci/prow/microshift-metal-tests-arm

In response to this:

/override ci/prow/microshift-metal-tests ci/prow/microshift-metal-tests-arm

Because test we're trying to fix here is using images from cache, it's not taking into consideration change in this PR. We need to merge this, so next night it's rebuilt.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jun 21, 2024

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Will open a ticket to remember this.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2024
Copy link
Contributor

openshift-ci bot commented Jun 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2c22273 into openshift:main Jun 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants