Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.16] OCPBUGS-35814: Fix CRI-O version to match Kubernetes version #3513

Merged
merged 3 commits into from
Jul 1, 2024
Merged

[release-4.16] OCPBUGS-35814: Fix CRI-O version to match Kubernetes version #3513

merged 3 commits into from
Jul 1, 2024

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented Jun 19, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 19, 2024
@openshift-ci-robot
Copy link

@pmtk: This pull request references Jira Issue OCPBUGS-35814, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-35814 to depend on a bug targeting a version in 4.17.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2024
@pmtk
Copy link
Member Author

pmtk commented Jun 19, 2024

/jira refresh

@openshift-ci-robot
Copy link

@pmtk: This pull request references Jira Issue OCPBUGS-35814, which is invalid:

  • expected dependent Jira Issue OCPBUGS-35507 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pmtk pmtk force-pushed the rpm-spec-crio-ver/release-4.16 branch 7 times, most recently from f759028 to 7a9f0fe Compare June 20, 2024 15:57
@pmtk
Copy link
Member Author

pmtk commented Jun 21, 2024

/test metal-periodic-test-arm

@pmtk
Copy link
Member Author

pmtk commented Jun 21, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 21, 2024
@openshift-ci-robot
Copy link

@pmtk: This pull request references Jira Issue OCPBUGS-35814, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-35507 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-35507 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
  • bug has dependents

Requesting review from QA contact:
/cc @jogeo

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from jogeo June 21, 2024 07:18
@pacevedom
Copy link
Contributor

/hold
until go/no go meeting today. We have until wednesday to merge it.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2024
@pmtk
Copy link
Member Author

pmtk commented Jun 25, 2024

/retest

@jogeo
Copy link
Contributor

jogeo commented Jun 27, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 27, 2024
@jerpeter1
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2024
@jerpeter1
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2024
@pacevedom
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 28, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8babeb9 and 2 for PR HEAD 704bb20 in total

@pmtk pmtk force-pushed the rpm-spec-crio-ver/release-4.16 branch from 704bb20 to 3e9453b Compare July 1, 2024 07:18
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2024
pmtk added 3 commits July 1, 2024 11:28
@pmtk
Fix CRI-O version to match Kubernetes version
a524381
@pmtk
Don't expect that previous RHOCP will be enabled on the system
1d1a392
@pmtk
Add --showduplicates to dnf repository-packages
24613dc 
If newer CRI-O is installed than CRI-O present in the inspected
repository then DNF will not consider it, meaning it will pretend like
there is no CRI-O in the inspected repository.

By adding --showduplicates DNF will show information about the CRI-O in
the repository regardless if newer is installed on the system or not.
@pmtk pmtk force-pushed the rpm-spec-crio-ver/release-4.16 branch from 3e9453b to 24613dc Compare July 1, 2024 09:29
@pmtk
Copy link
Member Author

pmtk commented Jul 1, 2024

/retest microshift-metal-tests

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 1, 2024

@pmtk: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test images
  • /test metal-periodic-test
  • /test metal-periodic-test-arm
  • /test microshift-metal-cache
  • /test microshift-metal-cache-arm
  • /test microshift-metal-tests
  • /test microshift-metal-tests-arm
  • /test ocp-conformance-rhel-eus
  • /test ocp-conformance-rhel-eus-arm
  • /test ocp-full-conformance-rhel-eus
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-release-4.16-images
  • pull-ci-openshift-microshift-release-4.16-metal-periodic-test
  • pull-ci-openshift-microshift-release-4.16-metal-periodic-test-arm
  • pull-ci-openshift-microshift-release-4.16-microshift-metal-tests
  • pull-ci-openshift-microshift-release-4.16-microshift-metal-tests-arm
  • pull-ci-openshift-microshift-release-4.16-test-rpm
  • pull-ci-openshift-microshift-release-4.16-test-unit
  • pull-ci-openshift-microshift-release-4.16-verify

In response to this:

/retest microshift-metal-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pmtk
Copy link
Member Author

pmtk commented Jul 1, 2024

/test microshift-metal-tests

[MIRROR] cri-o-1.29.5-5.rhaos4.16.git7032128.el9.x86_64.rpm: Curl error (28): Timeout was reached for https://cdn.redhat.com/content/dist/layered/rhel9/x86_64/rhocp/4.16/os/Packages/c/cri-o-1.29.5-5.rhaos4.16.git7032128.el9.x86_64.rpm [Operation too slow. Less than 1000 bytes/sec transferred the last 30 seconds]
(6/6): cri-o-1.29.5-5.rhaos4.16.git7032128.el9. 503 kB/s |  18 MB     00:37

but it got installed

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 1, 2024

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pmtk pmtk mentioned this pull request Jul 1, 2024
Closed
pacevedom
pacevedom approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerpeter1, pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jerpeter1,pacevedom,pmtk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3efd8a4 into openshift:release-4.16 Jul 1, 2024
9 checks passed
@openshift-ci-robot
Copy link

@pmtk: Jira Issue OCPBUGS-35814: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-35814 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pmtk pmtk deleted the rpm-spec-crio-ver/release-4.16 branch July 1, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacevedom pacevedom pacevedom approved these changes

@ggiguash ggiguash Awaiting requested review from ggiguash

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

@jogeo jogeo Awaiting requested review from jogeo

Assignees

@pacevedom pacevedom

@jerpeter1 jerpeter1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pmtk @openshift-ci-robot @pacevedom @jogeo @jerpeter1