Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.16] USHIFT-3318: Re-Enable Non-Upgrade Scenarios Which Depend on 4.17 mirrored rpms #3511

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #3470

/assign copejon

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 19, 2024

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: USHIFT-3319

In response to this:

This is an automated cherry-pick of #3470

/assign copejon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jerpeter1 and jogeo June 19, 2024 05:14
@ggiguash
Copy link
Contributor

/test metal-periodic-test microshift-metal-tests

@ggiguash
Copy link
Contributor

ggiguash commented Jun 19, 2024

/retitle [release-4.16] USHIFT-3318: Re-Enable Non-Upgrade Scenarios Which Depend on 4.17 mirrored rpms

@openshift-ci openshift-ci bot changed the title [release-4.16] USHIFT-3319: Re-Enable Non-Upgrade Scenarios Which Depend on 4.17 mirrored rpms [release-4.16] USHIFT-3318: Re-Enable Non-Upgrade Scenarios Which Depend on 4.17 mirrored rpms Jun 19, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 19, 2024

@openshift-cherrypick-robot: This pull request references USHIFT-3318 which is a valid jira issue.

In response to this:

This is an automated cherry-pick of #3470

/assign copejon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Contributor

/label backport-risk-assessed
/label jira/valid-bug

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 19, 2024
@copejon
Copy link
Contributor

copejon commented Jun 19, 2024

Failed during AWS infra deployment

/retest

@jerpeter1
Copy link
Member

/retest

@copejon
Copy link
Contributor

copejon commented Jun 28, 2024

For some reason, the PREVIOUS_RELEASE_REPO value is not being expanded when extract_container_images is called. The results is that the dnf download command inside extract_container_images is called without specifying the repo. It's weird, because the PREVIOUS_RELEASE_REPO value is calculated and set prior to the call.

This is also reproducible locally.

@copejon
Copy link
Contributor

copejon commented Jun 28, 2024

/retest

@copejon
Copy link
Contributor

copejon commented Jul 1, 2024

/test metal-periodic-test

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 2, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 2, 2024
@copejon
Copy link
Contributor

copejon commented Jul 2, 2024

/lgtm
/label cherry-pick-approved

Copy link
Contributor

openshift-ci bot commented Jul 2, 2024

@copejon: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/lgtm
/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2024
Copy link
Contributor

openshift-ci bot commented Jul 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2024
@jogeo
Copy link
Contributor

jogeo commented Jul 2, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 2, 2024
Copy link
Contributor

openshift-ci bot commented Jul 2, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5362213 into openshift:release-4.16 Jul 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants