Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-ISSUE: microshift-test-agent improvements #3463

Merged
merged 2 commits into from
Jul 1, 2024
Merged

NO-ISSUE: microshift-test-agent improvements #3463

merged 2 commits into from
Jul 1, 2024
+5 −3

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented Jun 10, 2024

  • Remove /bin/bash from the ExecStart so microshift-test-agent.sh is used in journal leading to easier debbuging.
  • Add 5s stop timeout, to (hopefully) not receive two SIGTERMs in a row which can lead to _cleanup function to running completely and breaking the test.
  • Don't fail if no file matches /etc/ssh/ssh_host*key wildcard

@pmtk
Change logging unit from bash to microshift-test-agent.sh
3a6df65 
Removing bash from ExecStart will cause journalctl to use
microshift-test-agent.sh instead of bash, leading to improve log
readability.
@openshift-ci-robot
Copy link

@pmtk: This pull request explicitly references no jira issue.

In response to this:

  • Remove /bin/bash from the ExecStart so microshift-test-agent.sh is used in journal leading to easier debbuging.
  • Add 5s stop timeout, to (hopefully) not receive two SIGTERMs in a row which can lead to _cleanup function to running completely and breaking the test.
  • Don't fail if no file matches /etc/ssh/ssh_host*key wildcard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 10, 2024
@openshift-ci openshift-ci bot requested review from copejon and jerpeter1 June 10, 2024 12:00
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2024
@pmtk
Copy link
Member Author

pmtk commented Jun 12, 2024

/test microshift-metal-tests

@copejon
Copy link
Contributor

copejon commented Jun 18, 2024

this lgtm. can you squash these changes before we merge?

@pmtk
Give service 5s to stop to avoid double SIGTERM
4023855 
Hopefully it won't receive two SIGTERMs in a row causing in _cleanup
function to not run completely and disrupting the test.
@pmtk pmtk force-pushed the test-agent/better-logs_try-wait-for-stop branch from 7f4eb4a to 1cfa74d Compare June 26, 2024 13:28
@ggiguash
Copy link
Contributor

/retest-required

@ggiguash
Copy link
Contributor

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 27, 2024

@ggiguash: The following commands are available to trigger required jobs:

  • /test images
  • /test metal-bootc-test
  • /test metal-bootc-test-arm
  • /test metal-periodic-test
  • /test metal-periodic-test-arm
  • /test microshift-metal-cache
  • /test microshift-metal-cache-arm
  • /test microshift-metal-tests
  • /test microshift-metal-tests-arm
  • /test ocp-conformance-rhel-eus
  • /test ocp-conformance-rhel-eus-arm
  • /test ocp-full-conformance-rhel-eus
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-microshift-metal-tests-arm
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ggiguash
Copy link
Contributor

/test metal-bootc-test
/test metal-bootc-test-arm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 27, 2024 •
edited
Loading

@pmtk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/metal-bootc-test-arm 1cfa74d link true /test metal-bootc-test-arm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pmtk pmtk force-pushed the test-agent/better-logs_try-wait-for-stop branch from 1cfa74d to 4023855 Compare July 1, 2024 10:58
@ggiguash
Copy link
Contributor

ggiguash commented Jul 1, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7486d68 into openshift:main Jul 1, 2024
6 checks passed
@ggiguash
Copy link
Contributor

ggiguash commented Aug 2, 2024

/cherry-pick release-4.16

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 2, 2024
Merged
@openshift-cherrypick-robot
Copy link

@ggiguash: new pull request created: #3713

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggiguash ggiguash ggiguash left review comments

@copejon copejon Awaiting requested review from copejon

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

Assignees

@ggiguash ggiguash

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pmtk @openshift-ci-robot @copejon @ggiguash @openshift-cherrypick-robot