Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-3177: Use only ipv4 addresses for default router #3407

Merged
merged 1 commit into from
May 29, 2024

Conversation

pacevedom
Copy link
Contributor

There was a mismatch between what the config package IP addresses from the host and the router controller. The config package only gets ipv4 addresses while the router controller takes ipv6 too. This caused a mismatch between allowed/configured IP addresses that triggered fake warning logs about ipv6 entries not allowed in the service (even if they were not configured).

Which issue(s) this PR addresses:

Closes #

There was a mismatch between what the config package IP addresses from
the host and the router controller. The config package only gets ipv4
addresses while the router controller takes ipv6 too. This caused a
mismatch between allowed/configured IP addresses that triggered fake
warning logs about ipv6 entries not allowed in the service (even if
they were not configured).
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 29, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 29, 2024

@pacevedom: This pull request references USHIFT-3177 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.16" instead.

In response to this:

There was a mismatch between what the config package IP addresses from the host and the router controller. The config package only gets ipv4 addresses while the router controller takes ipv6 too. This caused a mismatch between allowed/configured IP addresses that triggered fake warning logs about ipv6 entries not allowed in the service (even if they were not configured).

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from ggiguash and pmtk May 29, 2024 10:59
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2024
Copy link
Contributor

openshift-ci bot commented May 29, 2024

@pacevedom: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ggiguash
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2024
Copy link
Contributor

openshift-ci bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit fe5d840 into openshift:main May 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants