Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-533: Remove role (controlplane/node) config. #1065

Merged
merged 1 commit into from
Oct 31, 2022
Merged

USHIFT-533: Remove role (controlplane/node) config. #1065

merged 1 commit into from
Oct 31, 2022

Conversation

benluddy
Copy link
Contributor

Following earlier discussion (#1011 (comment)), let's wait to define the configuration surface until split role support arrives.

@benluddy
Copy link
Contributor Author

/assign @fzdarsky

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2022
@oglok
Copy link
Contributor

oglok commented Oct 31, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2022
@dgrisonnet
Copy link
Member

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, dgrisonnet, oglok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fzdarsky
Copy link
Contributor

fzdarsky commented Oct 31, 2022 •
edited
Loading

/hold

Isn’t this PR overshooting a bit? We wanted to ensure this knob isn’t exposed to users yet, not remove the role split (which we’re going to have to implement anyway) and the design discussion?

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2022
@fzdarsky
Copy link
Contributor

/hold cancel

Looking at this again, after removing the config option the remaining wiring probably isn't awfully relevant.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2022
@benluddy
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2022

@benluddy: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 90e341d into openshift:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mangelajo mangelajo Awaiting requested review from mangelajo

@oglok oglok Awaiting requested review from oglok

Assignees

@oglok oglok

@fzdarsky fzdarsky

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@benluddy @oglok @dgrisonnet @fzdarsky @openshift-merge-robot