Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update k8s deps #1704

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matejvasek
Copy link

Changes

Submitter Checklist

  • πŸ“ Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).

  • β™½ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.

  • ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).

  • πŸ“– If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.

  • πŸ§ͺ While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.

  • 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.

  • πŸ”Ž If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).

@matejvasek matejvasek marked this pull request as ready for review June 6, 2024 11:29
go.mod Outdated Show resolved Hide resolved
The k8s.io/client-go v1.5.2 is actually pretty old version despite the
fact is looks like it should be newer than v0.29.3.

Signed-off-by: Matej VaΕ‘ek <[email protected]>
@@ -52,10 +52,7 @@ require (
)

replace (
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I would like to see all replaces gone. But I keep this PR minimal.

@matejvasek
Copy link
Author

PTAL @vdemeester @chmouel

@chmouel
Copy link
Member

chmouel commented Jun 6, 2024

/ok-to-test

@chmouel
Copy link
Member

chmouel commented Jun 6, 2024

we usually do those after osp release (1.15 which comes in one or two weeks) and keep them in sync with tektoncd/pipeline k8s version do you need it now?

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 64.59%. Comparing base (3f9bcd0) to head (ca239bb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1704   +/-   ##
=======================================
  Coverage   64.59%   64.59%           
=======================================
  Files         144      144           
  Lines       11151    11151           
=======================================
  Hits         7203     7203           
  Misses       3422     3422           
  Partials      526      526           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@matejvasek
Copy link
Author

It's not urgent, but I would like to see fewer replaces as possible. It causes troubles for people using this repo as a library.

@matejvasek
Copy link
Author

matejvasek commented Jun 6, 2024

At very least I do not like seeing k8s.io/client-go v1.5.2 it is ancient version. The major version is a lie!

@chmouel
Copy link
Member

chmouel commented Jun 6, 2024

sounds good to me but as i say we mostly follow tektoncd/pipeline but it seems they removed the replaces they had before:

https://github.com/tektoncd/pipeline/blob/main/go.mod

so we good to cleanup and remove the replace as much as possible in there (and if it compiles it's fine)

ah yeah bear in mind we need to make sure to don't break openshift-pipelines/opc as well (which is a pain to maintain when deps divergs too much between all tektoncd projects)

(probably only will be merged post 1.15.x tho)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants