Add design document for multiples-url-to-the-same-repo feature #1644
Conversation
d5bce84
to
c3eb8c5
Compare
|
|
||
| The current implementation of the Repository CR allows specifying a single URL | ||
| for the repository. This is limiting in cases where the repository is mirrored | ||
| to multiple URLs. This document proposes a way to allow specifying multiple URLs |
There was a problem hiding this comment.
creating one CR for each repo?
is this a lot of work for this use case? or sharing the settings? across repos?
There was a problem hiding this comment.
I listed this in the alternatives sections that we could potentially reuse the configmap features of that setting you implemented sometime ago and extend it, but that's an admin thing that doesn't allow much flexibility...
sharing setting is an interesting idea,having a configmap reference that would embed the value..
There was a problem hiding this comment.
I think allowing multiple repo url could be a nice thing but if we allow regex then it might become quite complex as you have defined in scenarios
handling cases with multiple repos, what if a repo is edited and all
if the requirement for this design is to somehow share settings across repos then we could find someother way 🤔
There was a problem hiding this comment.
I don't think there is flow in the scenarios i have listed, it's just a matter to have the webhook check if the new value (on update or creation) matches already and fail otherwise? is there more complexities to it do you think?
There was a problem hiding this comment.
yeah webhook can handle that.
wdym by multiples-url-to-the-same-repo?
if we go with regex https://github.com/foo/.*
how it could be same repo?
differen repos can also be in this case right 🤔
Start adding design document for the multiple-url-to-same-repo feature. format of design may change in the future but this is good enough for a start i believe. Signed-off-by: Chmouel Boudjnah <[email protected]>
c3eb8c5
to
1cbbfc5
Compare
Start adding design document for the multiple-url-to-same-repo feature.
format of design may change in the future but this is good enough for a start i believe.
Changes
Submitter Checklist
📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).