Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hexdecimal literal string #6

Closed
wants to merge 2 commits into from

Conversation

cofyc
Copy link

@cofyc cofyc commented Oct 16, 2014

Fix these warnings only:

$ perl -l -e 'print $^V'
v5.16.2
$ perl t/03-pcre-testinput1-06.t  >/dev/null
Illegal hexadecimal digit '\' ignored at (eval 66) line 1, <DATA> line 1.
Illegal hexadecimal digit 'Z' ignored at (eval 66) line 1, <DATA> line 1.
Illegal hexadecimal digit '\' ignored at (eval 67) line 1, <DATA> line 1.
Illegal hexadecimal digit '\' ignored at (eval 70) line 1, <DATA> line 1.
Illegal hexadecimal digit 'Z' ignored at (eval 70) line 1, <DATA> line 1.

@agentzh
Copy link
Member

agentzh commented Oct 16, 2014

@cofyc Thank you for looking into this! But unfortunately it is wrong to manually edit the t/03-pcre-testinput1-06.t file directly because this file was generated automatically from the official PCRE test suite via the util/pcre_tests.pl script. Will you update the util/pcre_tests.pl accordingly instead? Thanks!

@agentzh
Copy link
Member

agentzh commented Oct 16, 2014

@cofyc BTW, the standard PCRE 8.32 source tarball was used to generate the current pcre tests in sregex :)

… 1 digit and followed by other character

2. [util/split-test-file.pl] reorder tests
3. regenerate t/03-pcre-testinput1* tests
@cofyc
Copy link
Author

cofyc commented Oct 17, 2014

Pushed a new commit: cofyc@8532033.
Regenerated tests by:

$ ./util/pcre_tests.pl -o t/03-pcre-testinput1.t_ testinput1
$ ./util/split-test-file.pl t/03-pcre-testinput1.t_ 

@agentzh
Copy link
Member

agentzh commented Oct 17, 2014

@cofyc Thanks! I'll look into this soon.

agentzh added a commit that referenced this pull request Oct 27, 2014
@agentzh
Copy link
Member

agentzh commented Oct 27, 2014

@cofyc Sorry for the delay on my side. Already applied a slightly modified version of your patch to git master :) Thanks again!

@agentzh agentzh closed this Oct 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants