bugfix: the connection won't be closed normally when set arg[1] = "" before arg[2] = true #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The ci error seems it has nothing to do with my changes |
|
@zhuizhuhaomeng @spacewander please help to review |
zhuizhuhaomeng
requested changes
Apr 9, 2024
| GET /t | ||
| --- response_body | ||
| --- no_error_log | ||
| [error] |
| GET /t | ||
| --- response_body | ||
| --- no_error_log | ||
| [error] |
spacewander
reviewed
Apr 10, 2024
t/082-body-filter-2.t
Outdated
| @@ -34,7 +34,7 @@ log_level('debug'); | |||
|
|
|||
| repeat_each(2); | |||
|
|
|||
| plan tests => repeat_each() * (blocks() * 5); | |||
| plan tests => repeat_each() * (blocks() * 5 - 4); | |||
There was a problem hiding this comment.
Better to use a positive number, so the plan number won't be negative when --- ONLY is given.
zhuizhuhaomeng
requested changes
Apr 10, 2024
src/ngx_http_lua_bodyfilterby.c
Outdated
| /* the "in" chain cannot be NULL and we set the "last_buf" or | ||
| * "last_in_chain" flag in the last buf of "in" */ | ||
| /* the "in" chain cannot be NULL except that we set arg[1] = "" | ||
| * before arg[2] = true*/ |
There was a problem hiding this comment.
Suggested change
| * before arg[2] = true*/ | |
| * before arg[2] = true | |
| */ |
zhuizhuhaomeng
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2301
The reason is that when we set
arg[1] = ""first, thelmcf->body_filter_chainwill be nullhttps://github.com/openresty/lua-nginx-module/blob/master/src/ngx_http_lua_bodyfilterby.c#L633-L646
https://github.com/openresty/lua-nginx-module/blob/master/src/ngx_http_lua_bodyfilterby.c#L668-L700
Then we can't set the right end flag
https://github.com/openresty/lua-nginx-module/blob/master/src/ngx_http_lua_bodyfilterby.c#L526-L549