feature: added new api function ngx.resolve which allows perform host… #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… name's resolution from Lua code using Nginx core's dynamic resolver.
agentzh
requested changes
Feb 20, 2019
agentzh
requested changes
Mar 7, 2019
| static void ngx_http_lua_resolve_empty_handler(ngx_resolver_ctx_t *ctx); | ||
| static ngx_int_t ngx_http_lua_resolve_resume(ngx_http_request_t *r); | ||
| static int ngx_http_lua_resolve_retval(ngx_http_lua_resolver_ctx_t *ctx, | ||
| lua_State *L); |
There was a problem hiding this comment.
Bad indentation. See the guide for details:
https://openresty.org/en/c-coding-style-guide.html
Also, make sure you run the ngx-releng tool mentioned in the guide as well. That tool should catch this.
|
This pull request is now in conflict :( |
zhuizhuhaomeng
force-pushed
the
master
branch
from
f924579
to
fef2581
Compare
|
This pull request is now in conflict :( |
|
This pull request is now in conflict :( |
|
This pull request is now in conflict :( |
|
This pull request is now in conflict :( |
|
This pull request is now in conflict :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… name's resolution from Lua code using Nginx core's dynamic resolver.
Please, check my new FFI-based implementation. Lua-part (openresty/lua-resty-core#235)
Let me propose a new API function for Lua - ngx.resolve. This function relies on Nginx core's dynamic resolver. This approach has several advantages e.g: common query cache for Nginx core & Lua code with ability to customize caching policy by DNS TTL/custom timeout.
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.