FLAG-77: Fix unit test execution issue during maven build #70
Conversation
pom.xml
Outdated
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <version>2.22.1</version> | ||
| <configuration> | ||
| <argLine>-Xmx512m -Djdk.net.URLClassPath.disableClassPathURLCheck=true</argLine> |
There was a problem hiding this comment.
Do we need this argLine?
There was a problem hiding this comment.
no, we don't need this argLine, I added this to fix the testNG suit issue, but the issue is still there.
pom.xml
Outdated
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <version>3.2.2</version> |
There was a problem hiding this comment.
Can't we use the same version as Java 8?
There was a problem hiding this comment.
we use the same version as used in java 8
There was a problem hiding this comment.
Just so you know, you don't need to state the version here explicitly. You could remove the version here.
ManojLL
force-pushed
the
FLAG-77
branch
2 times, most recently
from
82ce39c
to
9843f78
Compare
|
Do the tests work for you now? |
Tests are executing but stills having test suit issue |
|
@ManojLL Can we rename the PR name to reflect what we are achieving from this PR? |
pom.xml
Outdated
| @@ -204,5 +210,24 @@ | |||
| </properties> | |||
| </profile> | |||
|
|
|||
| <profile> | |||
There was a problem hiding this comment.
It would be great if we could get this as a different PR.
There was a problem hiding this comment.
If we remove this profile section, project build for Java 11 and Java 17 will fail for this PR
There was a problem hiding this comment.
We could rebase that commit to this pull request. So that won't be a problem.
There was a problem hiding this comment.
@ManojLL I merged the pull request for Java 17 support.
There was a problem hiding this comment.
I debase the branch with java 17 changes
pom.xml
Outdated
| @@ -119,6 +119,12 @@ | |||
| <version>${legacyuiVersion}</version> | |||
| <scope>provided</scope> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
yes, this decency is needed for java 17
There was a problem hiding this comment.
You could also add this to the Java 17 pull request.
ManojLL
changed the title
Issue worked on : FLAG-77