FLAG-69: Improve the performance of the evaluating all flags #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManojLL
changed the title
ManojLL
changed the title
wikumChamith
added a commit
that referenced
this pull request
Jun 24, 2024
)" This reverts commit 9891e4c.
ManojLL
pushed a commit
to ManojLL/openmrs-module-patientflags
that referenced
this pull request
Jun 24, 2024
…penmrs#60)" (openmrs#74) This reverts commit 9891e4c. FLAG 69 : resolve conflict
ManojLL
pushed a commit
to ManojLL/openmrs-module-patientflags
that referenced
this pull request
Jun 24, 2024
…penmrs#60)" (openmrs#74) This reverts commit 9891e4c. FLAG 69 : resolve conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I change
refactor evaluate all flags to process in parallel.
Issue Worked On
worked on FLAG-69
Test
Evaluate all flags 10 times
parallel process -> 74, 58 , 63 . 47 , 79, 40 , 101, 121 , 58 => avg 64.1 milliseconds
current module -> 258, 230, 215, 208, 207, 208, 204, 196,202, 198 => avg 212.6 milliseconds
evaluate all flags : PatientFlagTask.AllFlagsEvaluator