FLAG-73: upgrade openmrs version from 1.9.9 to 2.0.0 #58
Conversation
pom.xml
Outdated
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <uiframeworkVersion>3.11.0</uiframeworkVersion> | ||
| <metadatadeployVersion>1.8.1</metadatadeployVersion> | ||
| <metadatasharingVersion>1.2.2</metadatasharingVersion> | ||
| <webservices.rest-omod.version>2.40.0</webservices.rest-omod.version> | ||
| <legacyuiVersion>1.2.3</legacyuiVersion> | ||
| <omodHbmConfig> |
There was a problem hiding this comment.
Can you explain why you added this?
There was a problem hiding this comment.
we had a profile for platform 2.0.0, in there contains these properties for platform 2.0.0 so just add them to here.
There was a problem hiding this comment.
Do we get any errors if we don't include these?
There was a problem hiding this comment.
module build successfully without this properties.
omod/pom.xml
Outdated
| <artifactId>legacyui-omod</artifactId> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>javax.servlet</groupId> |
There was a problem hiding this comment.
Do we need this dependency?
There was a problem hiding this comment.
yes, without adding these dependencies we can not use legacy ui things in controllers.
There was a problem hiding this comment.
Do we get any errors without "javax.servlet-api" ?
There was a problem hiding this comment.
we can remove "javax.servlet-api" and I updated the changes
| @@ -107,18 +107,31 @@ | |||
| <version>${metadatasharingVersion}</version> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
Do we need both legacyui-omod and legacyui-api?
There was a problem hiding this comment.
I removed legacyui-api dependency
pom.xml
Outdated
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <uiframeworkVersion>3.11.0</uiframeworkVersion> | ||
| <metadatadeployVersion>1.8.1</metadatadeployVersion> | ||
| <metadatasharingVersion>1.2.2</metadatasharingVersion> | ||
| <webservices.rest-omod.version>2.40.0</webservices.rest-omod.version> | ||
| <legacyuiVersion>1.2.3</legacyuiVersion> |
There was a problem hiding this comment.
Did you try using a more recent version of legacyui?
There was a problem hiding this comment.
I updated it to latest legacy UI version
FLAG-73: remove unwanted dependencies and properties FLAG-73: remove unwanted dependencies FLAG-73: update legacy UI to latest version
Description of what I change
Upgrade the openMRS platform version from 1.9.9 to 2.0.0
Issue ### Worked On
worked on FLAG-73