LUI-161, Unable to edit the created alert in Users section #122
Conversation
| @@ -119,6 +119,8 @@ protected ModelAndView processFormSubmission(HttpServletRequest request, HttpSer | |||
| if (!userIds.contains(userId)) { | |||
| recipientsToRemove.add(recipient); | |||
| } | |||
| //To remove the users that have already been scheduled | |||
| userIds.remove(userId); | |||
There was a problem hiding this comment.
@Am-Coder done on this,have you tested this with a running instance of openmrs?
There was a problem hiding this comment.
Yup, I have verified the working using OpenMRS SDK on both distribution and platform server. Also tested this on OpenMRS-core separately by making use of the generated omod of legacy-ui module.
There was a problem hiding this comment.
I find your addition confusing because it is under a block for removing all recipients not in the userIds list. Which has nothing to do with clearing the userIds list.
There was a problem hiding this comment.
userIds hold the id's of users that will be called for scheduling as shown here . In this loop where I have added the change, all the recipients of alert are the recipients that have already been scheduled. These id's need to be removed from userIds , otherwise you will try to persist the duplicate and hence raise an exception.
That is why I added the change in the loop.
There was a problem hiding this comment.
Shouldn't it be in some sort of else clause?
There was a problem hiding this comment.
Else clause will be more appropriate. Made the changes.
There was a problem hiding this comment.
@dkayiwa , are some more changes needed for this PR ?
Description of what I changed
The already scheduled users need not be scheduled again. So, had to remove the already scheduled users.
Issue I worked On
see https://issues.openmrs.org/browse/LUI-161