(fix) O3-3350: Resolve infinite re-rendering of the dropdown component in the tablet viewport #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -248 kB (-19.68%) 🎉 Total Size: 1.01 MB
ℹ️ View Unchanged
|
|
Just tested on dev3 and this fix works as intended! Thanks, @samuelmale. |
pirupius
reviewed
Jun 21, 2024
| @@ -29,6 +29,7 @@ | |||
| "access": "public" | |||
| }, | |||
| "dependencies": { | |||
| "@carbon/react": ">1.47.0 <1.50.0", | |||
There was a problem hiding this comment.
@samuelmale Is there a specific reason you made this a dependency and not a peerDependency?
I've read the linked issues/pr and the issue with the downshift dependency in carbon which has since been resolved. After pulling the latest changes and linking with the form-builder, i got some errors from carbon because of version conflicts.
- On one end adding this range resolved the issue with the downshift library but it also creates either a conflict or multiple versions of
@carbon/reactrunning within microfrontends that have dependencies out of that range for example esm-form-builder and other esms are currently running on@carbon/react@npm:1.37.0which will in turn affect the bundle size. Would this necessitate us updating the frontends that pull the FE directly to at least1.47.0to have this fix working?
- Doesn't having the same range of versions as a peer dependency yield the same result but with the benefit of not duplicating instances of
@carbon/react?
There was a problem hiding this comment.
IIRC, the overwhelming consensus on the dependency management strategy for Carbon in O3 is having it as a normal dependency as opposed to a singleton (peer).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR fixes an issue with the dropdown component re-rendering infinitely on selecting an option in tablet view port. This issue stems from the "downshift" library consumed by Carbon and it seems to be affecting React v18. It was since resolved in downshift
v8.2.4and carbon.Out of scope
I've also changed Carbon from a peer dependency to a normal dependency.
Screenshots
Related Issue
https://issues.openmrs.org/browse/O3-3350
Other