Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) O3-3112: Add form collapse toggle to the esm-form-engine-app #1814

Merged
merged 5 commits into from
Apr 29, 2024
Merged

(feat) O3-3112: Add form collapse toggle to the esm-form-engine-app #1814

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
773aaef
feat: form collapse
usamaidrsk Apr 26, 2024
ffaeb59
refactor: rename formCollapseToggle
usamaidrsk Apr 26, 2024
e056ca8
refactor: remove redundant add lister
usamaidrsk Apr 26, 2024
08c056c
Merge branch 'main' into ft-form-collapse-toggle
denniskigen Apr 29, 2024
8366d6c
refactor: use usecallback for handleFormEmbedded
usamaidrsk Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: remove redundant add lister
  • Loading branch information
@usamaidrsk
usamaidrsk committed Apr 26, 2024
commit e056ca8c1869b01f88a1ecce75909734a6073f18
8 changes: 0 additions & 8 deletions packages/esm-form-engine-app/src/form-collapse-toggle/form-collapse-toggle.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,6 @@ const FormCollapseToggle = () => {
};
}, []);

useEffect(() => {
window.addEventListener('openmrs:form-collapse-toggle', null);

return () => {
window.removeEventListener('openmrs:form-collapse-toggle', null);
};
}, []);

const handleOnToggle = (value: boolean) => {
usamaidrsk marked this conversation as resolved.
Show resolved Hide resolved
const FormCollapseToggleEvent = new CustomEvent('openmrs:form-collapse-toggle', { detail: { value } });
window.dispatchEvent(FormCollapseToggleEvent);
Expand Down
Loading