-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Change allergy Onset date and comments
to Onset comments
#1530
Conversation
Size Change: -142 B (0%) Total Size: 10.5 MB ℹ️ View Unchanged
|
b9280f8
to
77612bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, @donaldkibet, I appreciate your pull request. As far as my understanding goes, the modification to include both the 'onset date' and 'comments' in a single field was a deliberate decision. This alteration enables users to input the onset date for an allergy within the comments section. The rationale behind this approach is that having a separate field for the onset date posed challenges. For instance, some patients may not be certain of the exact onset date, while others may only provide an estimate. By combining the onset date with the comments field, we aim to offer flexibility to users.
@gracepotma , could you kindly confirm?
@jayasanka-sack while it is OK to document both onset date and any comment in the control, users have expressed confusion as to whether there should be a date control or not. Their interpretation of the label is that the control has erroneously been missed. I support @donaldkibet in changing the label and I further propose that we update the placeholder text in the control to take care of an onset date, if available, and any comments |
P.S. Here's a screenshot from the updated allergy form #1525: |
The model does not have the onset date field, only date_created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @donaldkibet ,
Could you please change onset comments
to just Comments
?
Closing as stale. |
There is also no ticket for this change, and it would be a significant UI change. |
Requirements
Summary
Change the label for
Onset date and comments' to
Onset comments` to avoid indicating that the date is also captured on the controlScreenshots
Related Issue
Other