Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

O3-1524: Implement form viewer component #6

Merged
merged 2 commits into from
Sep 20, 2022
Merged

O3-1524: Implement form viewer component #6

merged 2 commits into from
Sep 20, 2022

Conversation

kumuditha-udayanga
Copy link
Member

Purpose

  • Implement the form viewer component to OpenMRS form builder using the OHRI form engine.
  • This component allows users to see a preview of the building form.

Screenshots

Screenshot 2022-09-14 at 11 36 44 PM

Screen.Recording.2022-09-14.at.11.37.49.PM.mov

samuelmale
samuelmale requested changes Sep 19, 2022
View reviewed changes
Copy link
Member

@samuelmale samuelmale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, just one minor comment.

src/components/form-editor/form-renderer/form-renderer.tsx Outdated Show resolved Hide resolved
@kumuditha-udayanga
Copy link
Member Author

Thank you for the review @samuelmale, the requested change is made

samuelmale
samuelmale approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@samuelmale samuelmale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelmale samuelmale merged commit e911e64 into openmrs:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelmale samuelmale samuelmale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kumuditha-udayanga @samuelmale