-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) Remove unnecessary useEffect #197
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -173 B (0%) Total Size: 2.98 MB ℹ️ View Unchanged
|
ODORA0
approved these changes
Oct 24, 2023
ibacher
changed the title
(refactor) Remove unnecessary useEffect
(fix) Remove unnecessary useEffect
Oct 24, 2023
ibacher
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR refactors the AuditDetails component, getting rid of an unnecessary useEffect and replacing it with a key so that whenever the key (which I've set to the form UUID) changes, React will recreate the DOM and reset the state of the
AuditDetails
.I've also removed a forgotten
console.log
statement and updated our eslint config with a rule that should flag uses ofconsole.log
in our codebase.Screenshots
unchanged-functionality.mp4
Related Issue
None
Other
None