Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Automatically extract translation strings #17

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Conversation

denniskigen
Copy link
Member

This PR sets up i18next-parser to automatically extract translation keys and strings from our code.

@pirupius
Copy link
Member

Hey @denniskigen please resolve the conflicts and build issues so we can get this in. It's been here a while

@denniskigen
Copy link
Member Author

denniskigen commented Dec 13, 2022

Are you aware of this TS error, @pirupius? (the screenshot is from the latest CI run). Looks like the TypeScript is complaining about the description argument getting passed to the showToast function in ohri-form.component.tsx.

Screenshot 2022-12-13 at 20 58 06

@pirupius
Copy link
Member

pirupius commented Dec 15, 2022

@denniskigen this is stemming from the rewrite of i18next to typescript in version 22. So the build issues go upto the esm-utils in the esm-core

see 2 options,

  1. Downgrade you package versions for i18next
  2. Upgrade the whole framework

The build seems to pass when these package versions

"i18next": "^19.7.0",
"i18next-parser": "^5.4.0",
"react-i18next": "^11.18.6",

@github-actions
Copy link

Size Change: 0 B 🆕

Total Size: 0 B

compressed-size-action

@denniskigen
Copy link
Member Author

Should be good to go. Thanks, @pirupius.

@pirupius pirupius merged commit dd2ad6b into main Dec 15, 2022
@denniskigen denniskigen deleted the chore/translations branch December 15, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants