OMRS-131: Detailed Audit Logging (Updated)

[wikumChamith]

Description of what I changed

I have enabled logging for tables that were omitted in the last PR. To identify these tables, I used the following SQL script to detect which tables lack corresponding audit tables:

SELECT table_name
FROM information_schema.tables
WHERE table_schema = 'openmrs'
  AND table_name NOT LIKE '%_AUD'
  AND table_name NOT IN (
    SELECT SUBSTRING_INDEX(table_name, '_AUD', 1)
    FROM information_schema.tables
    WHERE table_schema = 'openmrs'
      AND table_name LIKE '%_AUD'
);

Here are the tables currently without audit tables:

• OpenMRSRevisionEntity: This is a custom Hibernate Envers revision entity and does not require an audit table.
• concept_proposal_tag_map: Lacks a corresponding Hibernate entity or mapping.
• report_object: Lacks a corresponding Hibernate entity or mapping.
• user_property: Encountered an error when generating audit tables.
• report_schema_xml: Lacks a corresponding Hibernate entity or mapping.
• scheduler_task_config_property: Encountered an error when generating audit tables.
• liquibasechangeloglock: Lacks a corresponding Hibernate entity or mapping.
• note: Lacks a corresponding Hibernate entity or mapping.
• liquibasechangelog: Lacks a corresponding Hibernate entity or mapping.
• medication_dispense: Although it generates an audit table, it results in a test error when auditing is enabled.

Issue I worked on

see https://openmrs.atlassian.net/browse/OMRS-131

Checklist: I completed these to help reviewers :)

• My IDE is configured to follow the code style of this project.

  No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

• I have added tests to cover my changes. (If you refactored
  existing code that was well tested you do not have to add tests)

  No? -> write tests and add them to this commit git add . && git commit --amend

• I ran mvn clean package right before creating this pull request and
  added all formatting changes to my commit.

  No? -> execute above command

• All new and existing tests passed.

  No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

• My pull request is based on the latest changes of the master branch.

  No? Unsure? -> execute command git pull --rebase upstream master

[dkayiwa]

Can we rename the OpenMRSRevisionEntity table to match our table naming convention?

[dkayiwa]

Can you raise a pull request with medication_dispense such that i see the failure on github? I have so far failed to reproduce it locally.

[dkayiwa]

Are we using this anywhere?

[wikumChamith]

We are auditing Schedule entity

[dkayiwa]

Where in the codebase are we using that entity?

[wikumChamith]

I added auditing to it because it is used here:

openmrs-core/api/src/main/resources/org/openmrs/scheduler/db/hibernate/Schedule.hbm.xml

Line 16 in 3a7925a

<hibernate-mapping package="org.openmrs.scheduler">

However, I couldn't find any scheduler_schedule tables in the database.

[dkayiwa]

Looks like it may be time to get rid of it. 😊

[wikumChamith]

should I delete both the class and hbm?

[dkayiwa]

Yes, but in a separate pull request.

[wikumChamith]

I created a PR for this: #4670

[wikumChamith]

@dkayiwa I updated the revision entity name.

[wikumChamith]

Can you raise a pull request with medication_dispense such that i see the failure on github? I have so far failed to reproduce it locally.

I created a new PR for this: #4669

[dkayiwa]

Do we need the openmrs_ prefix?

[wikumChamith]

I updated the PR.

[dkayiwa]

And i think our naming convention has been Openmrs instead of OpenMRS. Not so? 😊

[wikumChamith]

I updated the class name.

[dkayiwa]

@wikumChamith can we fix these merge conflicts?