TRUNK-4004: Expose start_before_modules functionality better #4575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: For versions of OpenMRS without this commit, you must use a module element as a child of the start_before_modules element.
ibacher
added a commit
that referenced
this pull request
Mar 6, 2024
ibacher
added a commit
that referenced
this pull request
Mar 6, 2024
ibacher
added a commit
that referenced
this pull request
Mar 6, 2024
ibacher
added a commit
that referenced
this pull request
Mar 6, 2024
ibacher
added a commit
that referenced
this pull request
Mar 6, 2024
Seremba
pushed a commit
to Seremba/openmrs-core
that referenced
this pull request
Mar 13, 2024
Wandji69
pushed a commit
to Wandji69/openmrs-core
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
TRUNK-4004 (#923) added extremely useful functionality to allow modules to declare that the need to start before any arbitrary modules. However, the existence of this feature was never exposed through the DTDs and there were no tests for the parser for this feature, so this commit rounds things out a bit.
A note on the implementation:
To get the DTD to work without going absolutely insane, the DTD actually declares the support for
start_before_moduleas opposed to the originalmodule. The support forstart_before_moduleis added in this PR, so in older versions it may be necessary to use themodulekey instead ofstart_before_module. (The issue is that DTDs have a hard time with namespacing and the root element of config.xml is already calledmodule).Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master