Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK-6203: Global properties access should be privileged #4547

Closed
wants to merge 3 commits into from

Conversation

Seremba
Copy link
Contributor

@Seremba Seremba commented Jan 31, 2024

Description of what I changed

Refactored getGlobalProperty API method implementation to throw an authentication exception if user is not authenticated and property requested is not on a list of anonymously-accessible global properties. built a list of global properties that need to be available anonymously for startup. List is not yet fully exhausted.

Issue I worked on

see https://issues.openmrs.org/browse/TRUNK-

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@dkayiwa
Copy link
Member

dkayiwa commented Feb 1, 2024

@Seremba did you see the maven build failures?

@Seremba
Copy link
Contributor Author

Seremba commented Feb 1, 2024

Yes, @dkayiwa. they have been a challenge for several days even when I ran mvn clean package but I decided to create the PR so at least I can have a way of asking for help.

@wikumChamith
Copy link
Contributor

@Seremba there are a lot of formatting changes unrelated to this issue in your PR. You have created another PR for the formatting changes: #4548. That PR also contains the changes you made here. This is the wrong way of doing this.

Create separate branches from the master for both PRs and do not merge them. Can you take a good look at this: https://wiki.openmrs.org/display/docs/Pull+Request+Tips?

Every time you finish a branch and want to create another, you need to first switch to the master branch, and then create the new branch from there. If you do not do so, your pull request for the new branch will get mixed up with commits from the other branch

@Seremba Seremba closed this Feb 14, 2024
@Seremba Seremba deleted the TRUNK-6203 branch February 14, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants