Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK-6219: Obs should be considered a group if it ever had group members #4544

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

icrc-loliveira
Copy link
Contributor

Description of what I changed

On O3 if you try to void an obsGroup all is Obs it will fail with:

  • ['Obs #1551302' failed to validate with reason: error.noValue, valueText: Cannot be empty or null]
    This is due to the fact that all in Obs inside the obsGroup have already been voided and does not recognize it as an obsGroup.

Note: Please add this development to version 2.5.x

Issue I worked on

see https://openmrs.atlassian.net/browse/TRUNK-6219

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@icrc-loliveira
Copy link
Contributor Author

Hello @ibacher, Please review this PR, and if everything is OK port it to version 2.5.x

@ibacher ibacher changed the title Unable to void and ObsGroup and all child observations TRUNK-6219: Obs should be considered a group if it ever had group members Feb 7, 2024
@ibacher ibacher merged commit f32188c into openmrs:master Feb 7, 2024
6 checks passed
ibacher pushed a commit that referenced this pull request Feb 7, 2024
ibacher pushed a commit that referenced this pull request Feb 7, 2024
Wandji69 pushed a commit to Wandji69/openmrs-core that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants