TRUNK-6214: Update OpenMRS version in fix_liquibase_snapshots.sh scri… #4536
Conversation
…pt to current release
| @@ -17,6 +17,6 @@ | |||
| # The updated snapshots are written to the openmrs-core/liquibase/snapshots folder. | |||
| # | |||
|
|
|||
| openmrs_version=2.4.0-SNAPSHOT | |||
| openmrs_version=2.6.0-SNAPSHOT | |||
There was a problem hiding this comment.
we can extract the current OpenMRS version directly from the pom.xml file, So we no need to manually update the OpenMRS version during the release of a new version.
…ract the version from pom.xml
| @@ -17,6 +17,9 @@ | |||
| # The updated snapshots are written to the openmrs-core/liquibase/snapshots folder. | |||
| # | |||
|
|
|||
| openmrs_version=2.4.0-SNAPSHOT | |||
| pom_path="/mnt/c/Users/Admin/Desktop/development/openmrs-dev/openmrs-core/liquibase/pom.xml" | |||
There was a problem hiding this comment.
I'd like to suggest using relative paths instead absolute path. Absolute paths can lead to issues when the project is moved to a different directory or when others are working on the project from different environments.
|
Hi @ManojLL I am done adding the relative path |
|
|
||
| # Get the directory of the script | ||
| script_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" | ||
|
|
||
| # Search for the openmrs-core directory | ||
| project_dir="$script_dir" | ||
| while [[ "$project_dir" != "/" ]]; do | ||
| if [[ -d "$project_dir/openmrs-core" ]]; then | ||
| break | ||
| fi | ||
| project_dir="$(dirname "$project_dir")" | ||
| done | ||
|
|
||
| if [[ ! -d "$project_dir/openmrs-core" ]]; then | ||
| echo "Error: 'openmrs-core' directory not found" | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Construct the path to pom.xml and Check if the provided path exists | ||
| pom_path="$project_dir/openmrs-core/liquibase/pom.xml" | ||
|
|
||
| if [ ! -f "$pom_path" ]; then | ||
| echo "Error: $pom_path not found." | ||
| exit 1 | ||
| fi | ||
|
|
||
| version_line=$(grep '<version>' "$pom_path") | ||
|
|
||
| openmrs_version=$(echo "$version_line" | awk -F'[<>]' '{print $3}') |
There was a problem hiding this comment.
according to the instructions , we have to execute this script from openmrs-core/liquibase. Then we do not need to consider about the root folder things.
Instead, we can use this openmrs_version=$(grep -m 1 '<version>' pom.xml | sed -n 's/.*<version>\(.*\)<\/version>.*/\1/p') .
|
Can you include a link to the ticket as advised here? https://wiki.openmrs.org/display/docs/Pull+Request+Tips |
|
Thanks @dkayiwa , I am done. |
|
@Seremba did you test this and confirm that |
|
Yes @dkayiwa, I surely did! |
|
How did you test it? |
|
I |
The screenshot below is for the code. |
|
|
||
| java -jar ./target/openmrs-liquibase-${openmrs_version}-jar-with-dependencies.jar | ||
| openmrs_version=$(grep -m 1 '<version>' ../pom.xml | sed -n 's/.*<version>\(.*\)<\/version>.*/\1/p' | awk '{$1=$1;print}') |
There was a problem hiding this comment.
| openmrs_version=$(grep -m 1 '<version>' ../pom.xml | sed -n 's/.*<version>\(.*\)<\/version>.*/\1/p' | awk '{$1=$1;print}') | |
| openmrs_version=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout) |
…pt to current release using maven
…pt to current release
…ract the version from pom.xml
…pt to current release using maven
| openmrs_version=$(cd ../ && mvn help:evaluate -Dexpression=project.version -q -DforceStdout) | ||
|
|
||
|
|
||
| java -jar ./target/openmrs-liquibase-"${openmrs_version}"-jar-with-dependencies.jar |
There was a problem hiding this comment.
What was the motivation behind putting ${openmrs_version} in double quotes?
|
I have removed the double quotes @dkayiwa |
…pt to current release
Description of what I changed
Issue I worked on
see https://openmrs.atlassian.net/browse/TRUNK-6214
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master