Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK-6202 Replace Hibernate Criteria API with JPA for HibernateHL7DAO #4521

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

k4pran
Copy link
Contributor

@k4pran k4pran commented Dec 31, 2023

Description of what I changed

This task is to migrate the deprecated hibernate criteria to jpa criteria for the HibernateHL7DAO class. There was a lot of test coverage missing in this class that I have not added yet. It didn't seem to follow the same pattern as the other DAOs where there is an xml set up to initialize mocks in the database. If we need to cover these missing tests before merging I may need some guidance on this.

Issue I worked on

see https://issues.openmrs.org/browse/TRUNK-6202

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@k4pran k4pran marked this pull request as ready for review January 16, 2024 17:13
@dkayiwa dkayiwa merged commit 77a3cc4 into openmrs:master Jan 16, 2024
6 checks passed
@dkayiwa
Copy link
Member

dkayiwa commented Jan 16, 2024

@k4pran improving the test coverage would be great. But it is fine if you do not have the time to do it. The functionality of this class is no longer used as much as in the old days. It was heavily used by the now deprecated FormEntry module: https://wiki.openmrs.org/display/docs/formentry+module

Wandji69 pushed a commit to Wandji69/openmrs-core that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants