TRUNK-6202 Replace Hibernate Criteria API with JPA for HibernateConceptDAO

[k4pran]

Description of what I changed

This task is to migrate the deprecated hibernate criteria to jpa criteria for the HibernateConceptDAO class.

Additionally, I added some additional tests where I noticed gaps, I validated these tests with both the original hibernate code and the migrated JPA code.

There are a few changes I want to highlight where it wasn't a as direct translation from hibernate to JPA:

• I noticed some of the case matching was not consistent, for example here the isDatabaseStringComparisonCaseSensitive seemed the wrong way around.

• In JPA you can't order by a non-selected field in combination with distinct. In these cases I filtered by distinct outside of the query. An example of this can be seen here

Issue I worked on

see https://issues.openmrs.org/browse/TRUNK-6202

Checklist: I completed these to help reviewers :)

• My IDE is configured to follow the code style of this project.

  No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

• I have added tests to cover my changes. (If you refactored
  existing code that was well tested you do not have to add tests)

  No? -> write tests and add them to this commit git add . && git commit --amend

• I ran mvn clean package right before creating this pull request and
  added all formatting changes to my commit.

  No? -> execute above command

• All new and existing tests passed.

  No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

• My pull request is based on the latest changes of the master branch.

  No? Unsure? -> execute command git pull --rebase upstream master

[dkayiwa]

@k4pran did you find it uncomfortable creating the smaller pull requests? 😊

[k4pran]

@k4pran did you find it uncomfortable creating the smaller pull requests? 😊

Haha 😂. The plan was to do one DAO at a time to break them up but I guess this was a big DAO, I can try to break some of the larger DAOs into smaller PRs in the future but not sure if there is any natural way to divide them up except a few methods at a time?

[dkayiwa]

I can try to break some of the larger DAOs into smaller PRs in the future but not sure if there is any natural way to divide them up except a few methods at a time?

No need to break larger DAOs. Let us go with what you have already done of one DAO at a time. 😊