Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Siva Reddy | BAH-2274 | Support for Java8 DateTime in jackson #4146

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Siva Reddy | BAH-2274 | Support for Java8 DateTime in jackson #4146

merged 1 commit into from
Sep 12, 2022

Conversation

sivareddyp
Copy link
Member

Description of what I changed

jackson starting from 2.12 version onwards needs dependency of com.fasterxml.jackson.datatype:jackson-datatype-jsr310 to process Java 8 date/time.

Issue I worked on

https://bahmni.atlassian.net/browse/BAH-2274

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@dkayiwa
Copy link
Member

dkayiwa commented Sep 12, 2022

@sivareddytw can i look at the complete full stack trace? I just want to create a small unit test for reproducing this.

@sivareddyp
Copy link
Member Author

sivareddyp commented Sep 12, 2022

@sivareddytw can i look at the complete full stack trace? I just want to create a small unit test for reproducing this.

@dkayiwa thanks for reviewing. Stack Trace added here.

@dkayiwa
Copy link
Member

dkayiwa commented Sep 12, 2022

@sivareddytw which version of the webservices rest module are you running?
The current webservices rest module uses the oldorg.codehaus.jackson.map.ObjectMapper for json serialisation, which i would not expect to result into that error. Are you using com.fasterxml.jackson.databind.ObjectMapper any where?

@sivareddyp
Copy link
Member Author

sivareddyp commented Sep 12, 2022

@sivareddytw which version of the webservices rest module are you running? The current webservices rest module uses the oldorg.codehaus.jackson.map.ObjectMapper for json serialisation, which i would not expect to result into that error. Are you using com.fasterxml.jackson.databind.ObjectMapper any where?

@dkayiwa we are using Rest Web Services OMOD - 2.33.0.
we are not using com.fasterxml.jackson.databind.ObjectMapper .

@dkayiwa
Copy link
Member

dkayiwa commented Sep 12, 2022

@sivareddytw do you know of how i can locally reproduce this?

@sivareddyp
Copy link
Member Author

sivareddyp commented Sep 12, 2022

@sivareddytw do you know of how i can locally reproduce this?

@dkayiwa we experienced this issue in Appointments Display Control of Patient's clinical dashboard.
If we want, we can get into a zoom call.

@dkayiwa
Copy link
Member

dkayiwa commented Sep 12, 2022

@sivareddytw do you think you can come up with a unit test to reproduce it?

@dkayiwa dkayiwa merged commit f7e2e47 into openmrs:master Sep 12, 2022
dkayiwa pushed a commit that referenced this pull request Sep 12, 2022
@dkayiwa
Copy link
Member

dkayiwa commented Sep 12, 2022

I have cherry picked to the 2.5.x branch at: 1dae8f6

suubi-joshua pushed a commit to suubi-joshua/openmrs-core that referenced this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants