Trunk-5225:Get list of OrderGroups by patient or encounter is missing in openmrs… #3084
Conversation
| @Test | ||
| public void getOrderGroupsByEncounter_shouldGetOrderGroupsFrommMultipleEncounters() { | ||
| Encounter existingEncounter1 = Context.getEncounterService().getEncounter(3); | ||
| Encounter existingEncounter2 = Context.getEncounterService().getEncounter(6); |
There was a problem hiding this comment.
What is the use of this test? Do we have any such tests in the existing code?
There was a problem hiding this comment.
the purpose of this test is to create instances of multiple encounters and they do exist in the existing code
| public void getOrderGroupsByPatient_shouldGetOrderGroupsFromMultiplePatients() { | ||
|
|
||
| Patient existingPatient1 = Context.getPatientService().getPatient(7); | ||
| Patient existingPatient2 = Context.getPatientService().getPatient(2); |
There was a problem hiding this comment.
What is the use of this test? Do we have any such tests in the existing code?
There was a problem hiding this comment.
the purpose of this test is to create instances of multiple patients and they do exist in the existing code
There was a problem hiding this comment.
Can you point me to any tests that you found doing the same?
There was a problem hiding this comment.
your right @dkayiwa the tests are not there, am going to remove them and only maintain the tests relating to getting order groups from a patient
|
Can you include the ticket id in your commit message as recommended at? https://wiki.openmrs.org/display/docs/Pull+Request+Tips |
gitcliff
changed the title
|
oh sorry about this, had forgotten it,,, |
| @Test | ||
| public void getOrderGroupsByEncounter_shouldGetOrderGroupsFromAnEncounter() { | ||
| Encounter existingEncounter = Context.getEncounterService().getEncounter(4); | ||
| List<OrderGroup> ordergroups1 = Context.getOrderService().getOrderGroupsByEncounter(existingEncounter); |
There was a problem hiding this comment.
What is the reason for appending 1 to the variable name?
| public void getOrderGroupsByPatient_shouldGetOrderGroupsGivenPatient() { | ||
|
|
||
| Patient existingPatient1 = Context.getPatientService().getPatient(8); | ||
| List<OrderGroup> ordergroups1 = Context.getOrderService().getOrderGroupsByPatient(existingPatient1); |
There was a problem hiding this comment.
What is the reason for appending 1 to the variable name?
|
|
||
| Patient existingPatient1 = Context.getPatientService().getPatient(8); | ||
| List<OrderGroup> ordergroups1 = Context.getOrderService().getOrderGroupsByPatient(existingPatient1); | ||
|
|
There was a problem hiding this comment.
Is this empty line intentional?
There was a problem hiding this comment.
No, i have fixed it
| @Test | ||
| public void getOrderGroupsByPatient_shouldGetOrderGroupsGivenPatient() { | ||
| Patient existingPatient = Context.getPatientService().getPatient(8); | ||
| List<OrderGroup> ordergroups1 = Context.getOrderService().getOrderGroupsByPatient(existingPatient); |
link:https://issues.openmrs.org/browse/TRUNK-5225
Get list of OrderGroups by patient or encounter is missing in openmrs…