Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK-5690 Fix typos in Javadoc comments in ConceptServiceImplTest file #3079

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

prathamesh-mutkure
Copy link
Contributor

@prathamesh-mutkure prathamesh-mutkure commented Dec 10, 2019

Description of what I changed

I've fixed some typos in the javadoc comments in ConceptServiceImplTest file

Issue I worked on

see https://issues.openmrs.org/browse/TRUNK-5690

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).

    No? -> read here on how to squash multiple commits into one

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 59.969% when pulling 500c02c on PrathameshMutkure:TRUNK-5690 into 38ad8e0 on openmrs:master.

Copy link
Member

@sherrif10 sherrif10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add Assert(expected outcome and actual results)

@dkayiwa dkayiwa merged commit 02515c0 into openmrs:master Dec 10, 2019
prathamesh-mutkure added a commit to prathamesh-mutkure/openmrs-core that referenced this pull request Dec 14, 2019
@prathamesh-mutkure prathamesh-mutkure deleted the TRUNK-5690 branch December 25, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants