GCI-142: Removed APIException #2781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Why are you removing the API Exception? |
|
Sonar pointed it out saying as it is a runtime exception it'll never run |
|
You need to give details of that. Or at least a link explaining so. For it is not correct to say that an APIException will never run. |
|
Should I write it in the PR itself? |
|
Whatever you can do to empower the reviewer with knowledge as to why you are raising this pull request. 😊 |
|
@dkayiwa alright 😊 |
|
I added the Sonar Issues in the PR itself. I hope this is sufficient 😃 |
|
Thanks @Bisht13 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
One of my changes from my PR #2780
Removing APIException
Sonar errors:-
https://goo.gl/3386fk
https://goo.gl/kLi4JP
https://goo.gl/KFE81t
https://goo.gl/1UVjLa
https://goo.gl/rR5MEx
https://goo.gl/27NHJX
https://goo.gl/vv1gza
https://goo.gl/g3AWcX
https://goo.gl/ZKkQ9U
Issue I worked on
see https://issues.openmrs.org/browse/GCI-142
Task Instance https://codein.withgoogle.com/dashboard/task-instances/6187644498214912/
Checklist: I completed these to help reviewers :)
My pull request only contains ONE single commit
My IDE is configured to follow the [code style]
I have added tests to cover my changes.
I ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
All new and existing tests passed.
My pull request is based on the latest changes of the master branch.