TRUNK-4929: PersonName.compareTo should be controlled by a global property #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me based on the ticket comments. |
|
@Alex140159 you seem to have missed a few steps here https://wiki.openmrs.org/display/docs/Pull+Request+Tips |
|
@dkayiwa I set the ticket to "Request Code Review" on JIRA. Was that all that I needed to do? |
|
Thanks @Ben-Waters for reviewing and approving this! 😊 Thanks @Alex140159 for working on it. |
jtatia
pushed a commit
to jtatia/openmrs-core
that referenced
this pull request
Aug 20, 2018
JyothsnaAshok
pushed a commit
to JyothsnaAshok/openmrs-core
that referenced
this pull request
Oct 23, 2018
JyothsnaAshok
added a commit
to JyothsnaAshok/openmrs-core
that referenced
this pull request
Oct 23, 2018
This reverts commit 7849dd1.
JyothsnaAshok
added a commit
to JyothsnaAshok/openmrs-core
that referenced
this pull request
Oct 23, 2018
This reverts commit 7849dd1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TRUNK-4929 PersonName.compareTo should be controlled by a global property
Description of what I changed
According to Darius Jazayeri, a new comparator class should be used instead of a global property control system, however, that class is already implemented with PersonByNameComparator. Therefore, it was determined that the TODO comment should be removed, and the ticked closed. I removed the comment so that the ticket can be closed.
Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-4929
Checklist: I completed these to help reviewers :)
My pull request only contains ONE single commit
(the number above, next to the 'Commits' tab is 1).
My IDE is configured to follow the code style of this project.
I have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
I ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
All new and existing tests passed.
My pull request is based on the latest changes of the master branch.