TRUNK-5388 Make ModuleFileParser MessageSourceService dependency explicit #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icit new * add constructor ModuleFileParser(MessageSourceService) to clearly state dependencies, which enables easier testing by passing in a mock or use of a different implementation of a MessageSourceService * add method ModuleFileParser.parse(File) * add method ModuleFileparser.parse(InputStream) which provide the same functionality/use the same implementation underneath deprecate * deprecate all other constructors (3 in total) * deprecate parse() in favor of parse(File), there is no need to keep the file as state. This way we can create one parser and reuse it by just passing in a different file to parse tests * move all tests which do not need the Context to be there to the ModuleFileParserUnitTest which is now BaseContextMockTest and uses mocks of the MessageSourceService * one test still needs to stay in the BaseContextSensitive test since the Context.getLocale() is still called. Did not add Locale as dependency since I think this specific method getMessage(String key, Object[] args) should be implementated in the MessageSourceService as is getMessage(String) which abstracts away the users current locale for us
with ModuleFileParser(MessageSourceService) * in ModuleFactory * in ModuleExtensionsTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-5388