Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trunk 2119 -- Update Exception Reporting Screen to ask for User's Name, Subject, Email and Recent Steps #161

Merged
merged 2 commits into from
Feb 13, 2013
Merged

Trunk 2119 -- Update Exception Reporting Screen to ask for User's Name, Subject, Email and Recent Steps #161

merged 2 commits into from
Feb 13, 2013

Conversation

gsluthra
Copy link
Contributor

Enhanced the exception reporting page to ask for User's Name, Subject, Email and Recent steps.
See JIRA for how the screen now looks.

Here are some of my comments on this pull request:

  1. All code has been written using plain Javascript. jQuery wasn't available to page. Should I have instead used jQuery?
  2. Double quotes in text area may break the javascript.
  3. Since I wasn't sure how to control the JIRA variable reading, I concatenated user Name & Email and Recent steps to Stack Trace element, so it shows up nicely in Description section of the issue. And, I modified error summary element to contain user entered summary.
  4. The email field has no email validation. Suggestions? Is it needed? It would be good to have I think.
  5. Subject is mandatory. Other fields are optional.
  6. Unit Tests? None have been written as of now.

@gsluthra
First cut UI changes to ask user for subject, name, email & what were…
9491c9f 
… you doing when the error occured.
@gsluthra
Modified to support passing all params to post user entered details a…
1ea1d20 
…bout the error (via a javascript function). Now description is pre-fixed before the stacktrace, and summary is user inputted, rather than taking exception toString
dkayiwa added a commit that referenced this pull request Feb 13, 2013
@dkayiwa
Merge pull request #161 from gsluthra/TRUNK-2119
b6495f0 
Trunk 2119 -- Update Exception Reporting Screen to ask for User's Name, Subject, Email and Recent Steps
@dkayiwa dkayiwa merged commit b6495f0 into openmrs:master Feb 13, 2013
RandilaP pushed a commit to RandilaP/openmrs-core that referenced this pull request Jul 31, 2023
@KorirC
Enhancement global nav (openmrs#161)
b2dd8ed 
* add ability to close app menu and use name when user clicks outside

* add ability to close app menu and use name when user clicks outside

* add ability to close app menu and use name when user clicks outside

* add ability to close app menu and use name when user clicks outside
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gsluthra @dkayiwa