Fixes of Sonar critical issues #1607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lluismf looks like you need to pull the latest upstream changes to fix the merge conflicts in this pull request. |
|
Done, it seems that DrugHandler was removed while I was doing changes. |
|
Something is wrong, I used a class DbUtil to close JDBC resources that apparently is not present in the CI jars. How can that be? It's a Maven dependency (databene-commons-0.4.9) |
|
@lluismf did i just take long to see this until it got out of date? :) |
|
I messed up with a new commit. I need to figure out how to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ci.openmrs.org/sonar/drilldown/issues/1865